Re: [PATCH RFCv3 7/9] s390x: prepare device memory address space

[David Hildenbrand]

On 27.07.20 11:56, Cornelia Huck wrote:
> On Fri, 24 Jul 2020 16:37:48 +0200
> David Hildenbrand <david@redhat.com> wrote:
> 
>> Let's allocate the device memory information and setup the device
>> memory address space. The RAM size returned via SCLP is not modified. Guest
>> OSs which support memory devices (like virtio-mem) are expected to
>> consult diag500(4).
>>
>> Signed-off-by: David Hildenbrand <david@redhat.com>
>> ---
>>  hw/s390x/s390-virtio-ccw.c         | 37 ++++++++++++++++++++++++++++++
>>  hw/s390x/sclp.c                    |  6 ++++-
>>  include/hw/s390x/s390-virtio-ccw.h |  3 +++
>>  3 files changed, 45 insertions(+), 1 deletion(-)
>>
> 
> (...)
> 
>> @@ -783,8 +817,11 @@ static void 
>> ccw_machine_5_0_instance_options(MachineState *machine)
>>  
>>  static void ccw_machine_5_0_class_options(MachineClass *mc)
>>  {
>> +    S390CcwMachineClass *s390mc = S390_MACHINE_CLASS(mc);
>> +
>>      ccw_machine_5_1_class_options(mc);
>>      compat_props_add(mc->compat_props, hw_compat_5_0, hw_compat_5_0_len);
>> +    s390mc->memory_devices_allowed = false;
> 
> I guess that needs to go one version up. (I plan to send the 5.2
> machines patch in the next days.)

Indeed!

-- 
Thanks,

David / dhildenb