Re: [PATCH v2 0/9] s390x/tcg: Implement some z14 facilities

[Cornelia Huck]

On Thu, 1 Oct 2020 19:03:39 +0200
David Hildenbrand <david@redhat.com> wrote:

> On 01.10.20 19:02, Cornelia Huck wrote:
> > On Mon, 28 Sep 2020 14:27:08 +0200
> > David Hildenbrand <david@redhat.com> wrote:
> >   
> >> With this patchset, I can boot a kernel compiled for z14 (requiring
> >> Miscellaneous-Instruction-Extensions Facility 2) (using -cpu max).
> >>
> >> I am currently working on "vector-enhancements facility 1", I have most
> >> stuff in place except:
> >> - VECTOR FP (MAXIMUM|MINIMUM): needs some manual work to cover all types of
> >>                                comparisons.
> >>
> >> Once we have that in place, we can convert the QEMU machine to a
> >> stripped-down z14.
> >>
> >> v1 -> v2:
> >> - "s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
> >>    S390_FEAT_MISC_INSTRUCTION_EXT2"
> >> -- Added
> >> - "s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)"
> >> -- Use new helper instead
> >> - "s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)"
> >> -- Tune comparisons in CC computation
> >>
> >> David Hildenbrand (9):
> >>   s390x/cpu_model: S390_FEAT_MISC_INSTRUCTION_EXT ->
> >>     S390_FEAT_MISC_INSTRUCTION_EXT2
> >>   s390x/tcg: Implement ADD HALFWORD (AGH)
> >>   s390x/tcg: Implement SUBTRACT HALFWORD (SGH)
> >>   s390x/tcg: Implement MULTIPLY (MG, MGRK)
> >>   s390x/tcg: Implement MULTIPLY HALFWORD (MGH)
> >>   s390x/tcg: Implement BRANCH INDIRECT ON CONDITION (BIC)
> >>   s390x/tcg: Implement MULTIPLY SINGLE (MSC, MSGC, MSGRKC, MSRKC)
> >>   s390x/tcg: We support Miscellaneous-Instruction-Extensions Facility 2
> >>   s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA)
> >>
> >>  target/s390x/cc_helper.c            | 32 +++++++++++++++++++
> >>  target/s390x/cpu_features_def.h.inc |  2 +-
> >>  target/s390x/gen-features.c         |  4 ++-
> >>  target/s390x/helper.c               |  2 ++
> >>  target/s390x/insn-data.def          | 12 ++++++++
> >>  target/s390x/internal.h             |  2 ++
> >>  target/s390x/translate.c            | 48 +++++++++++++++++++++++++++++
> >>  7 files changed, 100 insertions(+), 2 deletions(-)
> >>  
> > 
> > Thanks, applied.
> >   
> 
> Can you rename in patch #1 subject "s390x/cpu_model" ->
> "s390x/cpumodel"? Thanks!

As you wish :) Pushed out.