[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 02/20] s390x/tcg: Implement VECTOR BIT PERMUTE
|
From: |
David Hildenbrand |
|
Subject: |
Re: [PATCH v1 02/20] s390x/tcg: Implement VECTOR BIT PERMUTE |
|
Date: |
Thu, 1 Oct 2020 19:28:03 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 01.10.20 17:17, Richard Henderson wrote:
> On 9/30/20 9:55 AM, David Hildenbrand wrote:
>> + bit = !!(s390_vec_read_element8(v2, bit_nr / 8) &
>> + (0x80 >> (bit_nr % 8)));
>
> I think this would be clearer as
>
> bit = (s390_vec_read_element8(v2, bit_nr / 8)
> >> (7 - (bit_nr % 8))) & 1;
Can do, thanks!
>
> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
>
> r~
>
--
Thanks,
David / dhildenb