[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [PATCH 12/36] qdev: Make error_set_from_qdev_prop_error() get Object* argument |
|
Date: |
Fri, 30 Oct 2020 07:16:43 -0400 |
On Fri, Oct 30, 2020 at 12:00:33PM +0400, Marc-André Lureau wrote:
> On Fri, Oct 30, 2020 at 2:16 AM Eduardo Habkost <ehabkost@redhat.com> wrote:
>
> > Make the code more generic and not specific to TYPE_DEVICE.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> >
>
> What about dropping _qdev from the function name too?
I have a series that deletes the function completely, but I
decided to leave it outside of this first batch.
>
> Also, I am not sure it's a well designed function.. I would rather have 3
> different helper functions than dispatching with an errno... Might be worth
> a TODO note :)
>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Thanks!
--
Eduardo