Re: [PATCH v3] s390/kvm: fix diag318 propagation and reset functionality

[Thomas Huth]

On 24/11/2020 17.26, Collin Walling wrote:
> On 11/24/20 8:04 AM, Christian Borntraeger wrote:
>>
>> On 24.11.20 13:48, Christian Borntraeger wrote:
>>> Now that we have this - fully implemented in QEMU - shouldnt
>>> we add els and diag318 also to the default CPU models?
>>
>> At least the extended SCCB should be fine to be enabled all the 
>> time.
>>
> 
> Yeah ELS should be fine to default-enable since it's handled entirely
> via QEMU. If the kernel can support it, great. If not, then the kernel
> will simply provide the original 4K SCCB.
> 
> DIAG318 requires KVM support, so I do not think we should default-enable
> that one :)

Ok, but does ELS have any advantages as long as you don't use diag318? If we
do not enable diag318 by default, what sense does it make to enable ELS by
default?

 Thomas