Re: [PATCH RFC] tests/acceptance: add a test for devices on s390x

[Thomas Huth]

On 26/11/2020 13.05, Cornelia Huck wrote:
> On Wed, 25 Nov 2020 16:30:34 +0100
> Cornelia Huck <cohuck@redhat.com> wrote:
> 
>> On Wed, 25 Nov 2020 16:03:13 +0100
>> Thomas Huth <thuth@redhat.com> wrote:
>>
>>> On 25/11/2020 14.58, Cornelia Huck wrote:  
> 
>>>> +    def test(self):
>>>> +
>>>> +        """
>>>> +        :avocado: tags=arch:s390x
>>>> +        :avocado: tags=machine:s390-ccw-virtio
>>>> +        """
>>>> +
>>>> +        # XXX: switch to https when debian fixes their certificate
>>>> +        kernel_url = ('http://archive.debian.org/debian/dists/jessie/main'
>>>> +                      
>>>> '/installer-s390x/current/images/generic/kernel.debian')
>>>> +        kernel_hash = '5af1aa839754f4d8817fb5878b4d55dfc887f45d'
>>>> +        kernel_path = self.fetch_asset(kernel_url, asset_hash=kernel_hash)
>>>> +
>>>> +        initrd_url = ('http://archive.debian.org/debian/dists/jessie/main'
>>>> +                      
>>>> '/installer-s390x/current/images/generic/initrd.debian')
>>>> +        initrd_hash = '99252b28306184b876f979585e2d4bfe96b27464'
>>>> +        initrd_path = self.fetch_asset(initrd_url, asset_hash=initrd_hash)
>>>> +
>>>> +        self.vm.set_console()
>>>> +        kernel_command_line = (self.KERNEL_COMMON_COMMAND_LINE +
>>>> +                              'console=sclp0 root=/dev/ram0 BOOT_DEBUG=3')
>>>> +        self.vm.add_args('-nographic',
>>>> +                         '-kernel', kernel_path,
>>>> +                         '-initrd', initrd_path,
>>>> +                         '-append', kernel_command_line,
>>>> +                         '-device', 'virtio-net-ccw,devno=fe.1.1111',
>>>> +                         '-device', 'virtio-net-pci')    
>>>
>>> Maybe use '-device', 'virtio-net-pci,addr=6' or something similar to check a
>>> non-default PCI address, too?  
>>
>> Not sure if addr= will do the trick, I may need to add a zpci device.
> 
> It seems I need both a zpci device (to specify the uid) and a newer
> kernel (so that the uid is actually used to construct the address in
> the guest). I guess I should use snapshots.debian.org to get a stable
> link to a newer version?

Not sure ... I assume the links to archive.debian.org are less likely to
change? So maybe simply forget about testing a different PCI address for
now, the default should be good enough for a simple check.

 Thomas

PS: Seems like at least "ip addr" is working there already - so you could at
least check the MAC address setting?