|
From: | Willian Rampazzo |
Subject: | Re: [PATCH 0/3] tests/acceptance: Test virtio-rng and -balloon on s390x |
Date: | Fri, 11 Dec 2020 17:10:31 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 12/11/20 2:31 PM, Thomas Huth wrote:
Add two more simple tests to check that virtio-rng and virtio-balloon are at least (very) basically working on s390x. Based-on: 20201204121450.120730-1-cohuck@redhat.com Thomas Huth (3): tests/acceptance: Extract the code to clear dmesg and wait for CRW reports tests/acceptance/machine_s390_ccw_virtio: Test virtio-rng via /dev/hwrng tests/acceptance/machine_s390_ccw_virtio: Test the virtio-balloon device tests/acceptance/machine_s390_ccw_virtio.py | 59 +++++++++++++++------ 1 file changed, 43 insertions(+), 16 deletions(-)
One observation, test_s390x_devices tends to get longer and difficult to debug in case of problems. If a test covers one specific device type, It will improve readability, flexibility, and debugging. In case you don't want to spend time breaking this into multiple tests, I'll be glad to do that after the whole series is merged.
As far as code concerned, Reviewed-by: Willian Rampazzo <willianr@redhat.com> Tested-by: Willian Rampazzo <willianr@redhat.com>Fetching asset from tests/acceptance/machine_s390_ccw_virtio.py:S390CCWVirtioMachine.test_s390x_devices Fetching asset from tests/acceptance/machine_s390_ccw_virtio.py:S390CCWVirtioMachine.test_s390x_devices
JOB ID : 8ba8e572f2582f9a48f2542423342e51e257db97JOB LOG : /home/linux1/src/qemu.dev/build/tests/results/job-2020-12-11T15.01-8ba8e57/job.log (1/1) tests/acceptance/machine_s390_ccw_virtio.py:S390CCWVirtioMachine.test_s390x_devices: PASS (7.89 s) RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
JOB TIME : 8.03 s
[Prev in Thread] | Current Thread | [Next in Thread] |