[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vhost-user-fs: add the "bootindex" property
|
From: |
Cornelia Huck |
|
Subject: |
Re: [PATCH] vhost-user-fs: add the "bootindex" property |
|
Date: |
Mon, 11 Jan 2021 17:22:08 +0100 |
On Mon, 4 Jan 2021 14:24:01 +0100
Laszlo Ersek <lersek@redhat.com> wrote:
> virtio-fs qualifies as a bootable device minimally under OVMF, but
> currently the necessary "bootindex" property is missing (fw_cfg kernel
> boot notwithstanding).
>
> Add the property. For completeness, add it to the CCW device as well;
> other virtio-ccw devices seem to have "bootindex" properties too.
>
> Example OpenFirmware device path for the "vhost-user-fs-pci" device in the
> "bootorder" fw_cfg file:
>
> /pci@i0cf8/pci-bridge@1,6/pci1af4,105a@0/filesystem@0
>
> Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Cornelia Huck <cohuck@redhat.com>
> Cc: Halil Pasic <pasic@linux.ibm.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: qemu-s390x@nongnu.org
> Cc: virtio-fs@redhat.com
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> include/hw/virtio/vhost-user-fs.h | 1 +
> hw/s390x/vhost-user-fs-ccw.c | 2 ++
> hw/virtio/vhost-user-fs-pci.c | 2 ++
> hw/virtio/vhost-user-fs.c | 10 ++++++++++
> 4 files changed, 15 insertions(+)
>
I agree that you should just drop the ccw hunk for now. The rest of the
patch looks good to me.