[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] s390x: move S390_ADAPTER_SUPPRESSIBLE
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 1/3] s390x: move S390_ADAPTER_SUPPRESSIBLE |
|
Date: |
Wed, 17 Mar 2021 12:30:19 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/17/21 10:56 AM, Gerd Hoffmann wrote:
> The definition S390_ADAPTER_SUPPRESSIBLE was moved to "cpu.h", per
> suggestion of Thomas Huth. From interface design perspective, IMHO, not
> a good thing as it belongs to the public interface of
> css_register_io_adapters(). We did this because CONFIG_KVM requeires
Typo "requeires" -> "requires"
> NEED_CPU_H and Thomas, and other commenters did not like the
> consequences of that.
>
> Moving the interrupt related declarations to s390_flic.h was suggested
> by Cornelia Huck.
>
> Signed-off-by: Halil Pasic <pasic@linux.ibm.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> include/hw/s390x/css.h | 7 -------
> include/hw/s390x/s390_flic.h | 3 +++
> target/s390x/cpu.h | 9 ++++++---
> 3 files changed, 9 insertions(+), 10 deletions(-)