qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary
Date: Sat, 27 Mar 2021 19:37:05 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0

On 3/27/21 7:35 PM, Philippe Mathieu-Daudé wrote:
> On 3/27/21 7:19 PM, Thomas Huth wrote:
>> On 27/03/2021 15.54, Philippe Mathieu-Daudé wrote:
>>> Hi Thomas,
>>>

>>> 6 more candidates?
>>
>> No, since those use TYPE_SYS_BUS_DEVICE and thus require hw/sysbus.h.
> 
> Ah indeed, this line matches your patch changes:
> 
> $ git grep -l '#include "hw/sysbus.h"' hw \
>    | xargs git grep -L sysbus_ \
>    | xargs git grep -L 'SysBusDevice\s\+\w' \
>    | xargs grep -L SYS_BUS_DEVICE

I missed the 'git' while copy/pasting, I meant:

     | xargs git grep -L SYS_BUS_DEVICE

> 
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]