Re: patch s390x/tcg: Implement Miscellaneous-Instruction-Extensions Facility 3 for the s390x

[David Hildenbrand]

>> +/* SELECT */
>> +    C(0xb9f0, SELR,    RRF_a, MIE3, r2, r3, new, r1_32, sel, 0)
>> +    C(0xb9e3, SELGR,   RRF_a, MIE3, r2, r3, r1, 0, sel, 0)
>> +/* SELECT HIGH */
>> +    C(0xb9c0, SELFHR,  RRF_a, MIE3, r2, r3, new, r1_32h, sel, 0)
>> +
>>   /* SET ACCESS */
>>       C(0xb24e, SAR,     RRE,   Z,   0, r2_o, 0, 0, sar, 0)
>>   /* SET ADDRESSING MODE */
> 
> 
> I quickly verified that the mnemonics and binary instructions match.
> 
> One thing that might be missing:
> I could not find the POPCOUNT changes mentioned in SA22-7832-12
> 
> --snip--
> In addition, POPULATION COUNT includes a control
> in an M 3 field for counting the number of one bits in
> each byte or the entire 64-bit register.
> --snip--
> 
> Can you have a look?
> 

I most probably won't find time to have a look this week (reading the
PoP to catch corner cases takes time), but I'll add it on my todo list
for next week.

We should most probably split off the tests into a separate patch and
add some meat to the patch description ;)

Thanks!

-- 
Thanks,

David / dhildenb