[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 11/11] target/s390x: Fix writeback to v1 in helper_vstl
From: |
Richard Henderson |
Subject: |
[PATCH v3 11/11] target/s390x: Fix writeback to v1 in helper_vstl |
Date: |
Mon, 7 Mar 2022 15:53:58 -1000 |
Copy-paste error from vector load length -- do not write
zeros back to v1 after storing from v1.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/s390x/tcg/vec_helper.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target/s390x/tcg/vec_helper.c b/target/s390x/tcg/vec_helper.c
index ededf13cf0..48d86722b2 100644
--- a/target/s390x/tcg/vec_helper.c
+++ b/target/s390x/tcg/vec_helper.c
@@ -200,7 +200,6 @@ void HELPER(vstl)(CPUS390XState *env, const void *v1,
uint64_t addr,
addr = wrap_address(env, addr + 8);
cpu_stq_data_ra(env, addr, s390_vec_read_element64(v1, 1), GETPC());
} else {
- S390Vector tmp = {};
int i;
for (i = 0; i < bytes; i++) {
@@ -209,6 +208,5 @@ void HELPER(vstl)(CPUS390XState *env, const void *v1,
uint64_t addr,
cpu_stb_data_ra(env, addr, byte, GETPC());
addr = wrap_address(env, addr + 1);
}
- *(S390Vector *)v1 = tmp;
}
}
--
2.25.1
- Re: [PATCH v3 07/11] target/s390x: vxeh2: vector {load, store} byte reversed elements, (continued)
- [PATCH v3 08/11] target/s390x: vxeh2: vector {load, store} byte reversed element, Richard Henderson, 2022/03/07
- [PATCH v3 09/11] target/s390x: add S390_FEAT_VECTOR_ENH2 to cpu max, Richard Henderson, 2022/03/07
- [PATCH v3 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2, Richard Henderson, 2022/03/07
- [PATCH v3 11/11] target/s390x: Fix writeback to v1 in helper_vstl,
Richard Henderson <=
- Re: [PATCH v3 00/11] s390x/tcg: Implement Vector-Enhancements Facility 2, David Miller, 2022/03/07