Re: [PULL 13/18] tests/tcg: add vectorised sha512 versions

[Alex Bennée]

Thomas Huth <thuth@redhat.com> writes:

> On 01/03/2022 10.47, Alex Bennée wrote:
>> This builds vectorised versions of sha512 to exercise the vector code:
>>    - aarch64 (AdvSimd)
>>    - i386 (SSE)
>>    - s390x (MVX)
>>    - ppc64/ppc64le (power10 vectors)
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Message-Id: <20220225172021.3493923-14-alex.bennee@linaro.org>
> [...]
>> diff --git a/tests/tcg/s390x/Makefile.target 
>> b/tests/tcg/s390x/Makefile.target
>> index 1a7238b4eb..e53b599b22 100644
>> --- a/tests/tcg/s390x/Makefile.target
>> +++ b/tests/tcg/s390x/Makefile.target
>> @@ -25,3 +25,12 @@ run-gdbstub-signals-s390x: signals-s390x
>>     EXTRA_RUNS += run-gdbstub-signals-s390x
>>   endif
>> +
>> +# MVX versions of sha512
>> +sha512-mvx: CFLAGS=-march=z13 -mvx -O3
>> +sha512-mvx: sha512.c
>> +    $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)
>> +
>> +run-sha512-mvx: QEMU_OPTS+=-cpu max
>> +
>> +TESTS+=sha512-mvx
>
> When running "make check-tcg" on my s390x host, I'm now getting this error:
>
>  TEST    sha512-mvx on s390x
> qemu-s390x: warning: 'msa5-base' requires 'kimd-sha-512'.
> qemu-s390x: warning: 'msa5-base' requires 'klmd-sha-512'.
> make[2]: *** [../Makefile.target:156: run-sha512-mvx] Error 10

Hmm I see the warning but it doesn't fail for me. Dropping -cpu max
makes the working go away. I thought we needed it to ensure the CPU
model had s390x's vector instructions enabled.

> Any ideas how to fix this?
>
>  Thomas


-- 
Alex Bennée