[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 11/11] target/s390x: Fix writeback to v1 in helper_vstl
From: |
David Hildenbrand |
Subject: |
Re: [PATCH v4 11/11] target/s390x: Fix writeback to v1 in helper_vstl |
Date: |
Tue, 22 Mar 2022 09:39:58 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 |
On 22.03.22 01:04, David Miller wrote:
> From: Richard Henderson <richard.henderson@linaro.org>
>
Please add the Fixes line as well:
Fixes: 0e0a5b49ad58 ("s390x/tcg: Implement VECTOR STORE WITH LENGTH")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: David Miller <dmiller423@gmail.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/tcg/vec_helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target/s390x/tcg/vec_helper.c b/target/s390x/tcg/vec_helper.c
> index ededf13cf0..48d86722b2 100644
> --- a/target/s390x/tcg/vec_helper.c
> +++ b/target/s390x/tcg/vec_helper.c
> @@ -200,7 +200,6 @@ void HELPER(vstl)(CPUS390XState *env, const void *v1,
> uint64_t addr,
> addr = wrap_address(env, addr + 8);
> cpu_stq_data_ra(env, addr, s390_vec_read_element64(v1, 1), GETPC());
> } else {
> - S390Vector tmp = {};
> int i;
>
> for (i = 0; i < bytes; i++) {
> @@ -209,6 +208,5 @@ void HELPER(vstl)(CPUS390XState *env, const void *v1,
> uint64_t addr,
> cpu_stb_data_ra(env, addr, byte, GETPC());
> addr = wrap_address(env, addr + 1);
> }
> - *(S390Vector *)v1 = tmp;
> }
> }
--
Thanks,
David / dhildenb
- [PATCH v4 10/11] tests/tcg/s390x: Tests for Vector Enhancements Facility 2, (continued)
- [PATCH v4 05/11] target/s390x: vxeh2: vector shift double by bit, David Miller, 2022/03/21
- [PATCH v4 03/11] target/s390x: vxeh2: vector string search, David Miller, 2022/03/21
- [PATCH v4 07/11] target/s390x: vxeh2: vector {load, store} byte reversed elements, David Miller, 2022/03/21
- [PATCH v4 11/11] target/s390x: Fix writeback to v1 in helper_vstl, David Miller, 2022/03/21
- Re: [PATCH v4 11/11] target/s390x: Fix writeback to v1 in helper_vstl,
David Hildenbrand <=
- [PATCH v4 09/11] target/s390x: add S390_FEAT_VECTOR_ENH2 to qemu CPU model, David Miller, 2022/03/21
- [PATCH v4 08/11] target/s390x: vxeh2: vector {load, store} byte reversed element, David Miller, 2022/03/21
- [PATCH v4 02/11] target/s390x: vxeh2: vector convert short/32b, David Miller, 2022/03/21
- [PATCH v4 04/11] target/s390x: vxeh2: Update for changes to vector shifts, David Miller, 2022/03/21