Re: [PATCH v1 1/2] s390x/cpu_models: drop "msa5" from the TCG "max" model

[Cornelia Huck]

On Tue, Mar 22 2022, David Hildenbrand <david@redhat.com> wrote:

> We don't include the "msa5" feature in the "qemu" model because it
> generates a warning. The PoP states:
>
> "The message-security-assist extension 5 requires
> the secure-hash-algorithm (SHA-512) capabilities of
> the message-security-assist extension 2 as a prereq-
> uisite. (March, 2015)"
>
> As SHA-512 won't be supported in the near future, let's just drop the
> feature from the "max" model. This avoids the warning and allows us for
> making the "max" model match the "qemu" model (except for compat
> machines). We don't lose much, as we only implement the function stubs
> for MSA, exclusing any real subfunctions.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/897
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  target/s390x/gen-features.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>