Re: [PATCH v5 7/9] s390x/pci: enable adapter event notification for interpreted devices

[Pierre Morel]

On 4/4/22 20:17, Matthew Rosato wrote:
> Use the associated kvm ioctl operation to enable adapter event notification
> and forwarding for devices when requested.  This feature will be set up
> with or without firmware assist based upon the 'forwarding_assist' setting.
>
> Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
>   hw/s390x/s390-pci-bus.c         | 20 ++++++++++++++---
>   hw/s390x/s390-pci-inst.c        | 40 +++++++++++++++++++++++++++++++--
>   hw/s390x/s390-pci-kvm.c         | 30 +++++++++++++++++++++++++
>   include/hw/s390x/s390-pci-bus.h |  1 +
>   include/hw/s390x/s390-pci-kvm.h | 14 ++++++++++++
>   5 files changed, 100 insertions(+), 5 deletions(-)
>
> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
> index 9c02d31250..47918d2ce9 100644
> --- a/hw/s390x/s390-pci-bus.c
> +++ b/hw/s390x/s390-pci-bus.c
> @@ -190,7 +190,10 @@ void s390_pci_sclp_deconfigure(SCCB *sccb)
>           rc = SCLP_RC_NO_ACTION_REQUIRED;
>           break;
>       default:
> -        if (pbdev->summary_ind) {
> +        if (pbdev->interp && (pbdev->fh & FH_MASK_ENABLE)) {
> +            /* Interpreted devices were using interrupt forwarding */
> +            s390_pci_kvm_aif_disable(pbdev);

Same remark as for the kernel part.
The VFIO device is already initialized and the action is on this device, 
Shouldn't we use the VFIO device interface instead of the KVM interface?


regards,
Pierre


--
Pierre Morel
IBM Lab Boeblingen