Re: [PATCH qemu] target/s390x: support PRNO_TRNG instruction

[Jason A. Donenfeld]

Hi Thomas,

On Tue, Jul 19, 2022 at 12:00 PM Thomas Huth <thuth@redhat.com> wrote:
> > +{
> > +        uint64_t addr = wrap_address(env, buf);
>
> I think you have to limit "len" to the lower 32-bit if not running in 64-bit
> mode.

Will do.

> According to the Principles of Operation:
>
> "A specification exception is recognized and no other
> action is taken if any of the following conditions exist:
> ...
> The R1 or R2 fields designate an odd-numbered
> register or general register 0. This exception is
> recognized regardless of the function code."
>
> It would be good to have that check here, too.

Ack.

v2 incoming.

Regards,
Jason