Re: [PATCH v2] target/s390x: support PRNO_TRNG instruction

[David Hildenbrand]

>> Again, what about the warning? We don't want to report warnings in the
>> QEMU default.
> 
> The change to cpu_models.c above gets rid of the warning.

Ah, stupid me. I missed that hunk somehow completely.

[...]

>> We have to be careful in 24-bit an 31-bit address mode, we may only
>> update selected parts of the registers.
>>
>> See target/s390x/tcg/mem_helper.c:set_address() as an example on how to
>> modify parts of registers using deposit64().
> 
> That's not pretty, but I think I see how to do it.
> 
> New revision incoming. Thanks for the review!

Thanks Jason!


-- 
Thanks,

David / dhildenb