Re: [PATCH v4 08/17] dump: Split write of section headers and data and add a prepare step

[Janosch Frank]

On 7/29/22 19:16, Janis Schoetterl-Glausch wrote:
> On 7/26/22 11:22, Janosch Frank wrote:
> > By splitting the writing of the section headers and (future) section
> > data we prepare for the addition of a string table section and
> > architecture sections.
> >
> > At the same time we move the writing of the section to the end of the
> > dump process. This allows the upcoming architecture section code to
> > add data after all of the common dump data has been written.
> >
> > Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> > ---
> >   dump/dump.c           | 112 ++++++++++++++++++++++++++++++++----------
> >   include/sysemu/dump.h |   4 ++
> >   2 files changed, 90 insertions(+), 26 deletions(-)
[...]
> > +    /* Write special section first */
> > +    if (s->phdr_num == PN_XNUM) {
>
> Should be >= right?

Yes, just fixed it.

> > +        prepare_elf_section_hdr_zero(s);
> > +    }
> > +}
> > +
> [...]