qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v11 01/11] s390x: Register TYPE_S390_CCW_MACHINE properties a


From: Pierre Morel
Subject: Re: [PATCH v11 01/11] s390x: Register TYPE_S390_CCW_MACHINE properties as class properties
Date: Fri, 4 Nov 2022 11:16:43 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1



On 11/4/22 07:32, Thomas Huth wrote:
On 03/11/2022 18.01, Pierre Morel wrote:
Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
---
  hw/s390x/s390-virtio-ccw.c | 127 +++++++++++++++++++++----------------
  1 file changed, 72 insertions(+), 55 deletions(-)

-EMISSINGPATCHDESCRIPTION

... please add some words *why* this is a good idea / necessary.

I saw that the i386 patch had no description for the same patch so...

To be honest I do not know why it is necessary.
The only reason I see is to be in sync with the PC implementation.

So what about:
"
Register TYPE_S390_CCW_MACHINE properties as class properties
to be conform with the X architectures
"
?

@Cédric , any official recommendation for doing that?


  Thanks,
   Thomas



--
Pierre Morel
IBM Lab Boeblingen



reply via email to

[Prev in Thread] Current Thread [Next in Thread]