[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PULL 28/30] multifd: Fix flush of zero copy page send request
From: |
Duan, Zhenzhong |
Subject: |
RE: [PULL 28/30] multifd: Fix flush of zero copy page send request |
Date: |
Thu, 9 Feb 2023 01:27:52 +0000 |
Hi Juan,
>-----Original Message-----
>From: Juan Quintela <quintela@redhat.com>
>Sent: Tuesday, February 7, 2023 8:57 AM
>To: qemu-devel@nongnu.org
>Cc: qemu-block@nongnu.org; Stefan Berger <stefanb@linux.vnet.ibm.com>;
>Stefan Hajnoczi <stefanha@redhat.com>; Halil Pasic <pasic@linux.ibm.com>;
>John Snow <jsnow@redhat.com>; David Hildenbrand <david@redhat.com>;
>Fam Zheng <fam@euphon.net>; Thomas Huth <thuth@redhat.com>; Daniel P.
>Berrangé <berrange@redhat.com>; Laurent Vivier <lvivier@redhat.com>;
>Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>; qemu-
>s390x@nongnu.org; Christian Borntraeger <borntraeger@linux.ibm.com>;
>Marc-André Lureau <marcandre.lureau@redhat.com>; Michael S. Tsirkin
><mst@redhat.com>; Juan Quintela <quintela@redhat.com>; Philippe
>Mathieu-Daudé <philmd@linaro.org>; Dr. David Alan Gilbert
><dgilbert@redhat.com>; Marcel Apfelbaum <marcel.apfelbaum@gmail.com>;
>Coiby Xu <Coiby.Xu@gmail.com>; Ilya Leoshkevich <iii@linux.ibm.com>;
>Eduardo Habkost <eduardo@habkost.net>; Yanan Wang
><wangyanan55@huawei.com>; Richard Henderson
><richard.henderson@linaro.org>; Markus Armbruster <armbru@redhat.com>;
>Paolo Bonzini <pbonzini@redhat.com>; Alex Williamson
><alex.williamson@redhat.com>; Eric Blake <eblake@redhat.com>; Eric
>Farman <farman@linux.ibm.com>; Duan, Zhenzhong
><zhenzhong.duan@intel.com>
>Subject: [PULL 28/30] multifd: Fix flush of zero copy page send request
>
>From: Zhenzhong Duan <zhenzhong.duan@intel.com>
>
>Make IO channel flush call after the inflight request has been drained in
>multifd thread, or else we may missed to flush the inflight request.
>
>Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
>Reviewed-by: Juan Quintela <quintela@redhat.com>
>Signed-off-by: Juan Quintela <quintela@redhat.com>
>---
> .../x86_64-quintela-devices.mak | 7 +
> .../x86_64-quintela2-devices.mak | 6 +
> migration/multifd.c | 8 +-
> migration/multifd.c.orig | 1274 +++++++++++++++++
> 4 files changed, 1291 insertions(+), 4 deletions(-) create mode 100644
>configs/devices/x86_64-softmmu/x86_64-quintela-devices.mak
> create mode 100644 configs/devices/x86_64-softmmu/x86_64-quintela2-
>devices.mak
> create mode 100644 migration/multifd.c.orig
>
Just back from vacation, hoping it's not too late to report:
x86_64-quintela-devices.mak x86_64-quintela2-devices.mak and multifd.c.orig
might be unrelated to this patch?
Thanks
Zhenzhong
- [PULL 18/30] virtio-mem: Migrate immutable properties early, (continued)
- [PULL 18/30] virtio-mem: Migrate immutable properties early, Juan Quintela, 2023/02/06
- [PULL 19/30] virtio-mem: Proper support for preallocation with migration, Juan Quintela, 2023/02/06
- [PULL 20/30] migration: Show downtime during postcopy phase, Juan Quintela, 2023/02/06
- [PULL 21/30] migration/rdma: fix return value for qio_channel_rdma_{readv, writev}, Juan Quintela, 2023/02/06
- [PULL 22/30] migration: Add canary to VMSTATE_END_OF_LIST, Juan Quintela, 2023/02/06
- [PULL 23/30] migration: Perform vmsd structure check during tests, Juan Quintela, 2023/02/06
- [PULL 24/30] migration/dirtyrate: Show sample pages only in page-sampling mode, Juan Quintela, 2023/02/06
- [PULL 25/30] io: Add support for MSG_PEEK for socket channel, Juan Quintela, 2023/02/06
- [PULL 27/30] multifd: Fix a race on reading MultiFDPages_t.block, Juan Quintela, 2023/02/06
- [PULL 28/30] multifd: Fix flush of zero copy page send request, Juan Quintela, 2023/02/06
- RE: [PULL 28/30] multifd: Fix flush of zero copy page send request,
Duan, Zhenzhong <=
- [PULL 26/30] migration: check magic value for deciding the mapping of channels, Juan Quintela, 2023/02/06
- [PULL 29/30] migration: Introduce interface query-migrationthreads, Juan Quintela, 2023/02/06
- [PULL 30/30] migration: save/delete migration thread info, Juan Quintela, 2023/02/06
- Re: [PULL 00/30] Migration 20230206 patches, Peter Maydell, 2023/02/07