Re: [PATCH v4] kconfig: Add PCIe devices to s390x machines

[Cédric Le Goater]

> > diff --git a/hw/s390x/Kconfig b/hw/s390x/Kconfig
> > index 454e0ff4b613..4c068d7960b9 100644
> > --- a/hw/s390x/Kconfig
> > +++ b/hw/s390x/Kconfig
> > @@ -5,7 +5,8 @@ config S390_CCW_VIRTIO
> >       imply VFIO_AP
> >       imply VFIO_CCW
> >       imply WDT_DIAG288
> > -    select PCI
> > +    imply PCIE_DEVICES
> > +    select PCI_EXPRESS
>
> I'm confused, TYPE_S390_PCI_HOST_BRIDGE exposes a PCI bus...
> At a minimum you'd need:
>
> -- >8 --
>   static const TypeInfo s390_pcihost_info = {
>       .name          = TYPE_S390_PCI_HOST_BRIDGE,
> -    .parent        = TYPE_PCI_HOST_BRIDGE,
> +    .parent        = TYPE_PCIE_HOST_BRIDGE,
>       .instance_size = sizeof(S390pciState),
>       .class_init    = s390_pcihost_class_init,
>       .interfaces = (InterfaceInfo[]) {
> ---
>
> Actually I can see:
>
>          if (s390_pci_msix_init(pbdev) && !pbdev->interp) {
>              error_setg(errp, "MSI-X support is mandatory "
>                         "in the S390 architecture");
>              return;
>          }
>
> So this must be PCIe, not legacy PCI, right?

It seems difficult to change now without breaking migration compatibility.

C.