[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 04/14] target/s390x: Fix ICM with M3=0
From: |
Ilya Leoshkevich |
Subject: |
[PATCH v4 04/14] target/s390x: Fix ICM with M3=0 |
Date: |
Mon, 24 Jul 2023 10:15:57 +0200 |
When the mask is zero, access exceptions should still be recognized for
1 byte at the second-operand address. CC should be set to 0.
Cc: qemu-stable@nongnu.org
Fixes: e023e832d0ac ("s390x: translate engine for s390x CPU")
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
target/s390x/tcg/translate.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index d6e8acee995..244e61ad2eb 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -2515,6 +2515,12 @@ static DisasJumpType op_icm(DisasContext *s, DisasOps *o)
ccm = ((1ull << len) - 1) << pos;
break;
+ case 0:
+ /* Recognize access exceptions for the first byte. */
+ tcg_gen_qemu_ld_i64(tmp, o->in2, get_mem_index(s), MO_UB);
+ gen_op_movi_cc(s, 0);
+ return DISAS_NEXT;
+
default:
/* This is going to be a sequence of loads and inserts. */
pos = base + 32 - 8;
--
2.41.0
- [PATCH v4 00/14] target/s390x: Miscellaneous TCG fixes, part 2, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 01/14] target/s390x: Make CKSM raise an exception if R2 is odd, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 09/14] tests/tcg/s390x: Test CLGEBR and CGEBRA, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 11/14] tests/tcg/s390x: Test ICM, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 12/14] tests/tcg/s390x: Test MC, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 04/14] target/s390x: Fix ICM with M3=0,
Ilya Leoshkevich <=
- [PATCH v4 05/14] target/s390x: Make MC raise specification exception when class >= 16, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 06/14] tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 08/14] tests/tcg/s390x: Test CKSM, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 03/14] target/s390x: Fix CONVERT TO LOGICAL/FIXED with out-of-range inputs, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 02/14] target/s390x: Fix CLM with M3=0, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 13/14] tests/tcg/s390x: Test STPQ, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 14/14] tests/tcg/s390x: Test VCKSM, Ilya Leoshkevich, 2023/07/24
- [PATCH v4 10/14] tests/tcg/s390x: Test CLM, Ilya Leoshkevich, 2023/07/24