Re: [PATCH 0/7] audio related fixes for 10.1

[Volker Rümelin]

Am 13.05.25 um 08:40 schrieb Michael Tokarev:
> 11.05.2025 10:36, Volker Rümelin wrote:
>> A few audio related fixes for 10.1.
>>
>> The virtio-sound device is the first QEMU audio front end that
>> supports floating point samples. The audio subsystem is only
>> partially prepared for this. The commit message of patch 7/7 "audio:
>> add float sample endianness converters" has the details. The new code
>> paths in patch 7/7 are only compile tested. I don't have a big endian
>> host to test.
>>
>> checkpatch.pl complains about missing space characters in the type
>> punning macros in patch 7/7. I don't agree.
>>
>> Volker Rümelin (7):
>>    tests/functional: use 'none' audio driver for q800 tests
>>    audio: fix SIGSEGV in AUD_get_buffer_size_out()
>>    audio: fix size calculation in AUD_get_buffer_size_out()
>>    hw/audio/asc: fix SIGSEGV in asc_realize()
>>    hw/audio/asc: replace g_malloc0() with g_malloc()
>>    audio/mixeng: remove unnecessary pointer type casts
>>    audio: add float sample endianness converters
>>
>>   audio/audio.c                        | 11 +++-
>>   audio/audio_template.h               | 12 ++--
>>   audio/mixeng.c                       | 83 ++++++++++++++++++++++++----
>>   audio/mixeng.h                       |  6 +-
>>   hw/audio/asc.c                       |  9 ++-
>>   tests/functional/test_m68k_q800.py   |  3 +-
>>   tests/functional/test_m68k_replay.py |  3 +-
>>   7 files changed, 106 insertions(+), 21 deletions(-)
>
> It looks like (some of) these patches should go to 10.0-stable too,
> what do you think?

I would perhaps select patch 1/7 (‘tests/functional: use “none” audio
driver for q800 tests’). I don't see any serious bugs fixed by these
patches.

With best regards,
Volker

>
> Thanks,
>
> /mjt
>
>