[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] Bug #757654: UHCI fails to signal stall response patch
From: |
Jan Vesely |
Subject: |
[Qemu-trivial] Bug #757654: UHCI fails to signal stall response patch |
Date: |
Fri, 15 Apr 2011 22:57:00 +0200 |
Hi,
I'm sending a patch for bug #757654. The bug does not really break
anything it just makes USB error detection harder.
It's a quick fix and might need some polishing but it works (I am
currently using it).
thx,
jan
PS: I guess you need this line:
Signed-off-by: Jan Vesely <address@hidden>
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
index 346db3e..a51d89b 100644
--- a/hw/usb-uhci.c
+++ b/hw/usb-uhci.c
@@ -732,11 +732,21 @@ out:
case USB_RET_STALL:
td->ctrl |= TD_CTRL_STALL;
td->ctrl &= ~TD_CTRL_ACTIVE;
+ s->status |= UHCI_STS_USBERR;
+ *int_mask |= 0x02;
+ if (td->ctrl & TD_CTRL_IOC)
+ *int_mask |= 0x01;
+ uhci_update_irq(s);
return 1;
case USB_RET_BABBLE:
td->ctrl |= TD_CTRL_BABBLE | TD_CTRL_STALL;
td->ctrl &= ~TD_CTRL_ACTIVE;
+ s->status |= UHCI_STS_USBERR;
+ *int_mask |= 0x02;
+ if (td->ctrl & TD_CTRL_IOC)
+ *int_mask |= 0x01;
+ uhci_update_irq(s);
/* frame interrupted */
return -1;
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-trivial] Bug #757654: UHCI fails to signal stall response patch,
Jan Vesely <=