Re: [Qemu-trivial] [Qemu-devel] [PATCH trivial] Fix comment typos in hw/armv7m.c

[Andreas Färber]

Am 23.06.2011 um 12:35 schrieb Matthew Fernandez:

> On 23 June 2011 20:22, Andreas Färber <address@hidden> wrote:
> > Am 23.06.2011 um 02:59 schrieb Matthew Fernandez:
> > > Fix a couple of typos in comments.
> > >
> > > Signed-off-by: Matthew Fernandez <address@hidden>
> > > ----
> > > This patch doesn't touch any code and should (hopefully) not be
> > > controversial. There doesn't seem to be a maintainer for this file,
> > > but changes are trivial.
> > >
> > >
> > > diff --git a/hw/armv7m.c b/hw/armv7m.c
> > > index 72d010a..83f3393 100644
> > > --- a/hw/armv7m.c
> > > +++ b/hw/armv7m.c
> > > @@ -4,7 +4,7 @@
> > >  * Copyright (c) 2006-2007 CodeSourcery.
> > >  * Written by Paul Brook
> > >  *
> > > - * This code is licenced under the GPL.
> > > + * This code is licensed under the GPL.
> >
> > Nack. Licence is British English, license American English. It's  
> > not wrong.
> Licence is the noun in British English, while license in the noun in  
> American English. License is the correct verb in both.

Ah, you seem right.

> Nevertheless, I don't think this is worth debating. If there's  
> dissent I'm happy to drop the first part of the patch.

I would still suggest to separate the two issues, as Stefan W. has  
done before - one patch for all "acess" -> "access", and one for all  
"licenced" -> "licensed", rather than file-based changes. That reduces  
list traffic for such cosmetic issues.

It might be worth thinking about integrating the top 10 typos into  
checkpatch.pl.

Andreas