[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] darwin-user: Remove two unused v
Re: [Qemu-trivial] [Qemu-devel] [PATCH] darwin-user: Remove two unused variables
Fri, 22 Jul 2011 23:43:08 +0200
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:126.96.36.199) Gecko/20110617 Thunderbird/3.1.11
Am 22.07.2011 22:48, schrieb Andreas Färber:
Hi Stefan W.,
Am 20.07.2011 um 21:40 schrieb Stefan Weil:
darwin-user/signal.c:322: style: Unused variable: i
Variable 'err' is assigned a value that is never used
Does this really bug you? I'm a bit skeptical towards trying to fix
warnings in code that doesn't compile either way... (or does it by now?)
the warnings were the result of a static code inspection with
a program called cppcheck. I don't compile darwin code,
so I did not notice that the code does not compile.
Is there a good reason to keep those two unused variables?
Fixing the issue helps with static code analysis because
unnecessary manual code checks can be avoided.