[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/qdev: Don't crash if qdev_cre

From: Markus Armbruster
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/qdev: Don't crash if qdev_create(NULL, ...) fails
Date: Thu, 04 Aug 2011 08:55:34 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Peter Maydell <address@hidden> writes:

> If an attempt to create a qdev device on the default sysbus (by passing
> NULL as the bus to qdev_create) fails, print a useful error message
> rather than crashing trying to dereference a NULL pointer.

The special case bus == NULL is ugly, and should be removed.  But
rejecting simple bug fixes because we want some cleanup would be
blackmail, and only hurts users.

Reviewed-by: Markus Armbruster <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]