[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] darwin-user: Remove two unused v

From: Blue Swirl
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] darwin-user: Remove two unused variables
Date: Sun, 7 Aug 2011 09:39:31 +0000

Thanks, applied.

On Fri, Jul 22, 2011 at 9:43 PM, Stefan Weil <address@hidden> wrote:
> Am 22.07.2011 22:48, schrieb Andreas Färber:
>> Hi Stefan W.,
>> Am 20.07.2011 um 21:40 schrieb Stefan Weil:
>>> cppcheck report:
>>> darwin-user/signal.c:322: style: Unused variable: i
>>> darwin-user/signal.c:322: style:
>>> Variable 'err' is assigned a value that is never used
>> Does this really bug you? I'm a bit skeptical towards trying to fix
>> warnings in code that doesn't compile either way... (or does it by now?)
>> Andreas
> Hi Andreas,
> the warnings were the result of a static code inspection with
> a program called cppcheck. I don't compile darwin code,
> so I did not notice that the code does not compile.
> Is there a good reason to keep those two unused variables?
> Fixing the issue helps with static code analysis because
> unnecessary manual code checks can be avoided.
> Cheers,
> Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]