qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] virtio-9p: Fix syntax error in debug code


From: Stefan Weil
Subject: Re: [Qemu-trivial] [PATCH] virtio-9p: Fix syntax error in debug code
Date: Thu, 08 Sep 2011 18:17:08 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20110818 Iceowl/1.0b1 Icedove/3.0.11

Am 20.07.2011 11:44, schrieb Aneesh Kumar K.V:
On Wed, 20 Jul 2011 08:27:28 +0200, Stefan Weil <address@hidden> wrote:
This error was reported by cppcheck:

qemu/hw/9pfs/virtio-9p-debug.c:342:
error: Invalid number of character ({) when these macros are defined:
'DEBUG_DATA'.

Cc: Aneesh Kumar K.V <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
---
hw/9pfs/virtio-9p-debug.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/9pfs/virtio-9p-debug.c b/hw/9pfs/virtio-9p-debug.c
index 4636ad5..96925f0 100644
--- a/hw/9pfs/virtio-9p-debug.c
+++ b/hw/9pfs/virtio-9p-debug.c
@@ -295,7 +295,7 @@ static void pprint_data(V9fsPDU *pdu, int rx, size_t *offsetp, const char *name)

if (rx) {
count = pdu->elem.in_num;
- } else
+ } else {
count = pdu->elem.out_num;
}


Applied.

We also need to update virtio-9p-debug w.r.t the new co-routine
series. With co-routine we can have multiple 9p handler started
simultaneously.

-aneesh

Maybe this patch can be applied via qemu-trivial.
I simply would like to get it out of my list of open patches.

Thanks,
Stefan W.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]