[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] hw/tc58128.c: Remove unnecessary check for g_
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-trivial] [PATCH] hw/tc58128.c: Remove unnecessary check for g_malloc failure |
|
Date: |
Thu, 10 Nov 2011 11:35:33 +0000 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Nov 09, 2011 at 07:34:28PM +0000, Peter Maydell wrote:
> Remove a check for g_malloc failing: this never happens.
> Also use g_malloc rather than g_malloc0 as we immediately
> memset the entire region and so zero-initialising it is pointless.
> Spotted by Coverity (see bug 887883).
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/tc58128.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan