[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2] rtl8139: Fix invalid IO access alignment
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [PATCH v2] rtl8139: Fix invalid IO access alignment |
Date: |
Wed, 23 Nov 2011 09:27:33 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Nov 23, 2011 at 01:03:15AM +0000, Julian Pidancet wrote:
> This patch makes iPXE work with the rtl8139 emulation. The rtl8139
> driver in iPXE issues a 16bit access on the ChipCmd register
> (offset 0x37) to check the status of the rx buffer. The offset of the
> ioport access was getting fixed up to 0x36 in qemu, causing the value
> read in iPXE to be invalid.
>
> This fixes an issue with iPXE reporting timeouts during TFTP transfers.
>
> Reposting this here because it is trivial enough and the original post
> on qemu-devel didn't attract much attention.
>
> Also, the inw() which was causing the issue has been replaced with an
> inb() in upstream iPXE:
> https://git.ipxe.org/ipxe.git/commit/91dd64ad25baa27954a7518e73df4fca8a2d0c93
>
> Signed-off-by: Julian Pidancet <address@hidden>
> ---
> hw/rtl8139.c | 14 +-------------
> 1 files changed, 1 insertions(+), 13 deletions(-)
Thanks, applied to the trivial patches -next tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-next
Stefan