[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/8] notifier: switch to QLIST
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/8] notifier: switch to QLIST |
|
Date: |
Tue, 3 Jan 2012 11:54:48 +0000 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 02, 2012 at 07:00:30PM +0100, Paolo Bonzini wrote:
> void notifier_list_add(NotifierList *list, Notifier *notifier)
> {
> - QTAILQ_INSERT_HEAD(&list->notifiers, notifier, node);
> + QLIST_INSERT_HEAD(&list->notifiers, notifier, node);
> }
>
> -void notifier_list_remove(NotifierList *list, Notifier *notifier)
> +void notifier_remove(Notifier *notifier)
Why introduce this asymmetry with notifier_list_add() and
notifier_remove()? Please make the function names consistent.
Stefan
- [Qemu-trivial] [PATCH 0/8] qemu-queue cleanups, Paolo Bonzini, 2012/01/02
- [Qemu-trivial] [PATCH 5/8] qemu-queue: really simplify QSIMPLEQ, Paolo Bonzini, 2012/01/02
- [Qemu-trivial] [PATCH 8/8] block: use QSIMPLEQ for the AIO free list, Paolo Bonzini, 2012/01/02
- [Qemu-trivial] [PATCH 3/8] qed: switch to QTAILQ, Paolo Bonzini, 2012/01/02
- [Qemu-trivial] [PATCH 4/8] ccid: switch to QTAILQ, Paolo Bonzini, 2012/01/02
- [Qemu-trivial] [PATCH 6/8] qemu-queue: drop QCIRCLEQ, Paolo Bonzini, 2012/01/02
- [Qemu-trivial] [PATCH 2/8] block-migration: switch to QTAILQ, Paolo Bonzini, 2012/01/02