[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] hmp: Fix freeing of PciInfoList
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [PATCH] hmp: Fix freeing of PciInfoList |
Date: |
Thu, 12 Jan 2012 13:35:10 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 11, 2012 at 10:51:52AM -0500, Stefan Berger wrote:
> Remember the original PciInfoList in info_list and use
> the info variable to traverse the list.
>
> Signed-off-by: Stefan Berger <address@hidden>
>
> ---
> hmp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Thanks, applied to the trivial patches tree but see below:
https://github.com/stefanha/qemu/commits/trivial-patches
Your patch seems to use two columns instead of just one column for
'-'/'+'/' '. This confused both git-am(1) and patch(1). Perhaps you
can figure out why your patch was generated like this? It reminds me of
diff3 where there are two columns because it compares file A and B
against a common ancestor file.
> Index: qemu-git.pt/hmp.c
> ===================================================================
> --- qemu-git.pt.orig/hmp.c
> +++ qemu-git.pt/hmp.c
> @@ -486,17 +486,17 @@ static void hmp_info_pci_device(Monitor
>
> void hmp_info_pci(Monitor *mon)
> {
> - PciInfoList *info;
> + PciInfoList *info_list, info;
Missing '*' to make info a pointer too. Fails to build, I fixed this
when merging so don't worry about it.
Stefan