[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] Add object_property_get_child().

From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Add object_property_get_child().
Date: Thu, 16 Feb 2012 18:16:47 +0000

On 16 February 2012 17:39, Alexander Barabash
<address@hidden> wrote:
>    Add object_property_get_child().
>    Adding a direct accessor to a child property.
>    In the existing implementation, object_property_get() must be used,
>    with with a visitor, implementing the 'type_str' callback,
>    receiving the child's canonical path.
>    In the new implementation, the child is returned directly.
>    Link properties are resolved in the same way, as they are
>    when an absolute path is resolved.
>    Errors relevant to the operation, QERR_OBJECT_PROPERTY_NOT_FOUND

Not trivial (look at the length of it!).

>    Also, in the new implementation, some common sense refactoring was done
>    in the file 'qom/object.c' in the code extracting child and link
> properties.

If you find yourself writing a commit message with a paragraph
starting "Also" this almost always means you should split it
into more than one patch.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]