Re: [Qemu-trivial] [Qemu-devel] [PATCH] libcacard: Spelling and grammar fixes in documentation

[Alon Levy]

On Sun, Feb 26, 2012 at 06:18:04PM +0000, Peter Maydell wrote:
> On 26 February 2012 13:30, Stefan Weil <address@hidden> wrote:
> > @@ -217,10 +217,10 @@ the card using the following functions:
> >          VCardStatus vcard_add_applet(VCard *card, VCardApplet *applet);
> >
> >   Add an applet onto the list of applets attached to the card. Once an 
> > applet
> > -  has been added, it can be selected by it's aid, and then commands will be
> > +  has been added, it can be selected by its aid, and then commands will be
> 
> While you're changing this line, it looks like 'aid' here should be 'AID'
> (it is capitalised elsewhere in the doc except where referring to a function
> parameter name).
> 
> >   routed to it VCardProcessAPDU function. This function adopts the applet 
> > the
> >   passed int applet.
> 
> The sentence "This function..." clearly needs correcting as it doesn't
> make much sense as it stands, but I'm not sure what it should be changed to.

Asked Robert Relyea (address@hidden - I guess he should be in
MAINTAINERS, although he is not..) and the answer was:
 This function adopts the applet that is passed into it.

> 
> > Note: 2 applets with the same AID should not be added to
> > -  the same card. It's permissible to add more than one applet. Multiple 
> > applets
> > +  the same card. It is permissible to add more than one applet. Multiple 
> > applets
> >   may have the same VCardPRocessAPDU entry point.
> 
> -- PMM
>