[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] osdep: Remove local definition of macro offse
Re: [Qemu-trivial] [PATCH] osdep: Remove local definition of macro offsetof
Mon, 5 Mar 2012 16:53:14 +0000
On Mon, Mar 05, 2012 at 07:22:31AM +0100, Stefan Weil wrote:
> The macro offsetof is defined in stddef.h. It is conforming to
> the standards C89, C99 and POSIX.1-2001 (see man page), so it
> is a sufficiently old standard.
> Therefore chances are very high that QEMU never needs a local
> definition of this macro.
> osdep.h already includes stddef.h, so this patch simply removes
> the unneeded code from the files configure and osdep.h.
> If we ever need the local definition again, it should be added
> to compiler.h (the macro is usually provided with the compiler,
> it is not OS specific).
> Signed-off-by: Stefan Weil <address@hidden>
> configure | 14 --------------
> osdep.h | 3 ---
> 2 files changed, 0 insertions(+), 17 deletions(-)
Andreas and Peter, thanks for looking into whether it's safe to remove
offsetof(). I feel the risk is very low.
Thanks, applied to the trivial patches tree: