Re: [Qemu-trivial] [Qemu-devel] [PATCH for-1.1] libqtest: Fix socket_accept() to pass address_len

[Andreas Färber]

Am 28.05.2012 00:53, schrieb Andreas Färber:
> accept() expects address_len to point to the length of the sockaddr on
> input. Initialize it accordingly.
> 
> Resolves an assertion due to EFAULT on illumos.
> 
> Signed-off-by: Andreas Färber <address@hidden>

Ping? Verifiable by looking at the Linux man page.

/-F

> ---
>  tests/libqtest.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/tests/libqtest.c b/tests/libqtest.c
> index 6d333ef..1d73fd1 100644
> --- a/tests/libqtest.c
> +++ b/tests/libqtest.c
> @@ -74,6 +74,7 @@ static int socket_accept(int sock)
>      socklen_t addrlen;
>      int ret;
>  
> +    addrlen = sizeof(addr);
>      do {
>          ret = accept(sock, (struct sockaddr *)&addr, &addrlen);
>      } while (ret == -1 && errno == EINTR);