[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH] Makefile.hw: avoid overly large 'make clean' rm c

From: Peter Maydell
Subject: [Qemu-trivial] [PATCH] Makefile.hw: avoid overly large 'make clean' rm command
Date: Tue, 19 Jun 2012 15:55:38 +0100

Avoid 'make clean' producing an 'rm' command which has a lot
of duplicate 'hw//*.o' arguments, by using $(sort $(dir ..))
rather than $(dir $(sort ..)) so Make's sort function will
remove the duplicates for us. We can also remove the double
'//' safely because $(dir ..) is guaranteed to return a string
ending in '/'.

Signed-off-by: Peter Maydell <address@hidden>
Mostly cosmetic, although I guess there's a faint chance that expanding
all those hw/*.o would hit the command line argument buffer limit...

 Makefile.hw |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.hw b/Makefile.hw
index 2bcbaff..28fe100 100644
--- a/Makefile.hw
+++ b/Makefile.hw
@@ -19,8 +19,8 @@ all: $(hw-obj-y)
-       rm -f $(addsuffix /*.o, $(dir $(sort $(hw-obj-y))))
-       rm -f $(addsuffix /*.d, $(dir $(sort $(hw-obj-y))))
+       rm -f $(addsuffix *.o, $(sort $(dir $(hw-obj-y))))
+       rm -f $(addsuffix *.d, $(sort $(dir $(hw-obj-y))))
 # Include automatically generated dependency files
 -include $(patsubst %.o, %.d, $(hw-obj-y))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]