[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Use macro QEMU_PACKED for new pa
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Use macro QEMU_PACKED for new packed structures
Wed, 18 Jul 2012 17:33:58 +0100
On 18 July 2012 17:12, Stefan Weil <address@hidden> wrote:
> Since commit 541dc0d47f10973c241e9955afc2aefc96adec51,
> some new packed structures were added without using QEMU_PACKED.
> QEMU_PACKED is needed for compilations with MinGW.
> For other platforms nothing changes.
> The code was fixed using this command:
> git grep -la '__attribute__ ((packed))'|xargs perl -pi -e
> 's/__attribute__ \(\(packed\)\)/QEMU_PACKED/'
There's one in tcg/tcg.c as well, which you missed because
it doesn't have a space between the "__attribute__" and
(There are also some in some of the tcg-target.c files,
but those are cases of the packed attribute being applied
to individual struct members rather than a whole struct, so
I'm not entirely sure what we should do with those.)