[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] Use macro QEMU_PACKED for new pa

From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Use macro QEMU_PACKED for new packed structures
Date: Wed, 18 Jul 2012 17:51:17 +0100

On 18 July 2012 17:42, Stefan Weil <address@hidden> wrote:
> Am 18.07.2012 18:33, schrieb Peter Maydell:
>> On 18 July 2012 17:12, Stefan Weil <address@hidden> wrote:
>>> Since commit 541dc0d47f10973c241e9955afc2aefc96adec51,
>>> some new packed structures were added without using QEMU_PACKED.
>>> QEMU_PACKED is needed for compilations with MinGW.
>>> For other platforms nothing changes.
>>> The code was fixed using this command:
>>>      git grep -la '__attribute__ ((packed))'|xargs perl -pi -e
>>> 's/__attribute__ \(\(packed\)\)/QEMU_PACKED/'
>> There's one in tcg/tcg.c as well, which you missed because
>> it doesn't have a space between the "__attribute__" and
>> "((packed))".
>> (There are also some in some of the tcg-target.c files,
>> but those are cases of the packed attribute being applied
>> to individual struct members rather than a whole struct, so
>> I'm not entirely sure what we should do with those.)

> I noticed those, too, but did not change them because
> I think that they need more examination (see my comment
> in http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02373.html).

Fair enough.
Reviewed-by: Peter Maydell <address@hidden>

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]