[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] eepro100: fix simplified mode

From: Stefan Weil
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] eepro100: fix simplified mode
Date: Mon, 23 Jul 2012 18:28:58 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:14.0) Gecko/20120714 Thunderbird/14.0

Am 23.07.2012 11:25, schrieb address@hidden:
From: Christian Schilling <address@hidden>

A driver using simplified mode that works on real hardware
did not work in qemu.

Signed-off-by: Christian Schilling <address@hidden>
  hw/eepro100.c |    7 +++++++
  1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/hw/eepro100.c b/hw/eepro100.c
index 6279ae3..4a48372 100644
--- a/hw/eepro100.c
+++ b/hw/eepro100.c
@@ -774,6 +774,13 @@ static void tx_command(EEPRO100State *s)
  #if 0
          uint16_t tx_buffer_el = lduw_le_pci_dma(&s->dev, tbd_address + 6);
+        if (tbd_array == 0xffffffff) {
+            /* In simpliyfied mode there is no tbd_array. Instead the packet 
+             * starts right after the tcb_bytes field, and the packet size is
+             * equal to tcb_bytes */
+            tx_buffer_size = tcb_bytes;
+            tx_buffer_address = tbd_address;
+        }
          tbd_address += 8;
          TRACE(RXTX, logout
              ("TBD (simplified mode): buffer address 0x%08x, size 0x%04x\n",

Do you really think that's a trivial patch?

I have a different fix for simplified mode in my QEMU tree:


That version is implemented according to the Intel specifications
and avoids hacks for specific guest drivers.

Maybe you can give it a try.

If it works for you, I can put the changes needed for simplified mode
in a patch for QEMU git master.


Stefan Weil

reply via email to

[Prev in Thread] Current Thread [Next in Thread]