[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] Makefile: Avoid explicit list of directories

From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [PATCH] Makefile: Avoid explicit list of directories in clean target
Date: Tue, 31 Jul 2012 14:25:56 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Jul 31, 2012 at 02:01:35PM +0100, Peter Maydell wrote:
> Avoid having an explicit list of directories in the 'clean'
> target by using 'find' to remove all .o and .d files instead.
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> I figured that (unlike Makefile.target) we should probably take
> the xargs route here since otherwise the rm command line is huge...
> There's also an argument that there's not much point having a clean
> target in Makefile.target when this one blows away most of it anyway.
>  Makefile |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Looks fine but waiting for others to review in case there is a subtlety
that affects some build environments.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]