[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of
From: |
Blue Swirl |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target |
Date: |
Tue, 31 Jul 2012 17:02:41 +0000 |
On Tue, Jul 31, 2012 at 4:20 PM, Stefan Weil <address@hidden> wrote:
> Am 31.07.2012 17:51, schrieb Peter Maydell:
>>
>> On 31 July 2012 16:49, Stefan Weil <address@hidden> wrote:
>>>
>>> Yes, QEMU creates files in 3 levels. We could use
>>>
>>> rm -f *.[od] */*.[od] */*/*.[od]
>>>
>>> I suggest using the wrapper $(call quiet-command,...)
>>> to suppress printing of all removed file names.
>>
>>
>> My worry was not so much what we print as that we
>> might be exceeding the total command line length
>> limits on some systems (whether you did it this way
>> or via "rm -f $(find ...)").
>>
>> -- PMM
>
>
> That's quite possible:
>
> $ find -name "*.[od]"|wc
> 4862 4862 151329
> $ ls *.[od] */*.[od] */*/*.[od] */*/*/*.[od] */*/*/*/*.[od]|wc
> 4862 4862 141605
>
> (I was somewhat surprised to see that we use 5 levels of directories).
>
> The command line would be more than 140000 characters which is indeed very
> long.
>
> Separating .o and .d files and the levels reduces that number:
>
> $ ls *.o|wc
> 80 80 952
> $ ls */*.o|wc
> 819 819 20048
> $ ls */*/*.o|wc
> 1406 1406 45573
> $ ls */*/*/*.o|wc
> 87 87 2579
> $ ls */*/*/*/*.o|wc
> 16 16 796
>
> The 2nd and the 3rd level are potentially critical, but they could be
> split up further if needed.
>
> What about removing support for in-tree builds?
> For out-of-tree builds 'make distclean' is nearly trivial.
We could also recommend out of tree build for those hosts which have
command line restrictions (can they be detected?). Even better, always
warn if in tree build is detected.
>
> -- Stefan W.
>
>
- [Qemu-trivial] [PATCH] Makefile: Avoid explicit list of directories in clean target, Peter Maydell, 2012/07/31
- Re: [Qemu-trivial] [PATCH] Makefile: Avoid explicit list of directories in clean target, Stefan Hajnoczi, 2012/07/31
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Markus Armbruster, 2012/07/31
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Peter Maydell, 2012/07/31
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Markus Armbruster, 2012/07/31
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Daniel P. Berrange, 2012/07/31
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Peter Maydell, 2012/07/31
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Stefan Weil, 2012/07/31
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Peter Maydell, 2012/07/31
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Stefan Weil, 2012/07/31
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target,
Blue Swirl <=
Re: [Qemu-trivial] [Qemu-devel] [PATCH] Makefile: Avoid explicit list of directories in clean target, Eric Blake, 2012/07/31