[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH] exec.c: Remove out of date comment
From: |
Peter Maydell |
Subject: |
[Qemu-trivial] [PATCH] exec.c: Remove out of date comment |
Date: |
Wed, 1 Aug 2012 14:35:47 +0100 |
Remove an out of date comment: this comment used to be attached to
cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally
inserted a couple of other functions between the comment and its function.
It is in any case obsolete since (a) the function arguments it refers
to have been replaced with a single MemoryRegionSection* argument and
(b) the inability to handle regions whose offset_within_address_space
and offset_within_region aren't equally aligned was fixed as part of
the rewrite of this code.
Signed-off-by: Peter Maydell <address@hidden>
---
Pretty sure my analysis is right and this comment is out of date --
Avi, could you confirm that please?
exec.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/exec.c b/exec.c
index feb4795..22dff17 100644
--- a/exec.c
+++ b/exec.c
@@ -2240,14 +2240,6 @@ static void phys_sections_clear(void)
phys_sections_nb = 0;
}
-/* register physical memory.
- For RAM, 'size' must be a multiple of the target page size.
- If (phys_offset & ~TARGET_PAGE_MASK) != 0, then it is an
- io memory page. The address used when calling the IO function is
- the offset from the start of the region, plus region_offset. Both
- start_addr and region_offset are rounded down to a page boundary
- before calculating this offset. This should not be a problem unless
- the low bits of start_addr and region_offset differ. */
static void register_subpage(MemoryRegionSection *section)
{
subpage_t *subpage;
--
1.7.9.5
- [Qemu-trivial] [PATCH] exec.c: Remove out of date comment,
Peter Maydell <=