qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-i386: Report on error dur


From: Don Slutz
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-i386: Report on error during cpu_x86_register().
Date: Sun, 02 Sep 2012 19:40:27 -0400
User-agent: Thunderbird 2.0.0.23 (X11/20090825)

Blue Swirl wrote:
On Sat, Sep 1, 2012 at 8:47 PM, Don Slutz <address@hidden> wrote:
Send it to stderr before free of the details.

Signed-off-by: Don Slutz <address@hidden>
---
 target-i386/cpu.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 57c064f..5c0fef1 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1352,6 +1352,7 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
     }
     object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
     if (error_is_set(&error)) {
+        fprintf(stderr, "%s: %s\n", __FUNCTION__, error_get_pretty(error));

__func__ is preferred by checkpatch.pl and also GCC recommends using it:
http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html

         error_free(error);
         return -1;
     }
--
1.7.1


Somehow I forgot to run checkpatch.pl on this.  V2 soon.
  -Don



reply via email to

[Prev in Thread] Current Thread [Next in Thread]