[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] qemu-timer: Don't use RDTSC on 386s and 486s
From: |
Peter Maydell |
Subject: |
Re: [Qemu-trivial] [PATCH] qemu-timer: Don't use RDTSC on 386s and 486s |
Date: |
Fri, 23 Nov 2012 15:17:47 +0000 |
On 23 November 2012 15:15, Paolo Bonzini <address@hidden> wrote:
> Il 23/11/2012 16:12, Peter Maydell ha scritto:
>> Adjust the conditional which guards the implementation of
>>
>> -#elif defined(__i386__)
>> +#elif defined(__i586__)
>>
>> static inline int64_t cpu_get_real_ticks(void)
>> {
>>
>
> You should at least test __i686__ too:
>
> $ gcc -m32 -dM -E -x c /dev/null |grep __i
> #define __i686 1
> #define __i686__ 1
> #define __i386 1
> #define __i386__ 1
Yuck. I had assumed gcc would define everything from i386
on up when building for later cores.
-- PMM