Re: [Qemu-trivial] [Qemu-devel] [PATCH] arch_init/ram_load: add error message for block length mismatch

[Orit Wasserman]

On 12/06/2012 02:02 PM, Alon Levy wrote:
> Signed-off-by: Alon Levy <address@hidden>
> ---
>  arch_init.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch_init.c b/arch_init.c
> index e6effe8..84bca99 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -808,8 +808,10 @@ static int ram_load(QEMUFile *f, void *opaque, int 
> version_id)
>                      QLIST_FOREACH(block, &ram_list.blocks, next) {
>                          if (!strncmp(id, block->idstr, sizeof(id))) {
>                              if (block->length != length) {
> +                                fprintf(stderr, "Length mismatch: %s: %d "
> +                                        "in != %d\n", id, length,
> +                                        block->length);
>                                  ret =  -EINVAL;
> -                                goto done;
>                              }
>                              break;
>                          }
> 
Reviewed-by: Orit Wasserman <address@hidden>

But the real question is what did we break this time? can it be fixed?

Orit