Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] arch_init/ram_load: add error message for block length mismatch

[Stefan Hajnoczi]

On Thu, Dec 06, 2012 at 02:08:20PM +0200, Alon Levy wrote:
> Signed-off-by: Alon Levy <address@hidden>
> ---
> Please ignore previous version, accidentally removed goto done and used wrong
> format size specifiers.
> 
>  arch_init.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch_init.c b/arch_init.c
> index e6effe8..fba24f3 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -808,6 +808,9 @@ static int ram_load(QEMUFile *f, void *opaque, int 
> version_id)
>                      QLIST_FOREACH(block, &ram_list.blocks, next) {
>                          if (!strncmp(id, block->idstr, sizeof(id))) {
>                              if (block->length != length) {
> +                                fprintf(stderr, "Length mismatch: %s: %ld "
> +                                        "in != %ld\n", id, length,
> +                                        block->length);

Please use RAM_ADDR_FMT for ram_addr_t values.

Stefan