[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 03/11] hw/9pfs: Fix unchecked
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 03/11] hw/9pfs: Fix unchecked strdup() by converting to g_strdup() |
Date: |
Thu, 17 Jan 2013 12:19:51 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 16, 2013 at 06:32:12PM +0100, Markus Armbruster wrote:
> diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
> index 6eab7f7..74155fb 100644
> --- a/hw/9pfs/virtio-9p-device.c
> +++ b/hw/9pfs/virtio-9p-device.c
> @@ -94,7 +94,7 @@ VirtIODevice *virtio_9p_init(DeviceState *dev, V9fsConf
> *conf)
> exit(1);
> }
>
> - s->tag = strdup(conf->tag);
> + s->tag = g_strdup(conf->tag);
> s->ctx.uid = -1;
>
> s->ops = fse->ops;
s->tag is leaked. Want to send a follow-up patch to g_free() it?
[Qemu-trivial] [PATCH v2 05/11] spice: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
[Qemu-trivial] [PATCH v2 04/11] readline: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
[Qemu-trivial] [PATCH v2 09/11] libcacard: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
[Qemu-trivial] [PATCH v2 01/11] g_malloc(0) and g_malloc0(0) return NULL; simplify, Markus Armbruster, 2013/01/16
[Qemu-trivial] [PATCH v2 10/11] qapi: Fix unchecked strdup() by converting to g_strdup(), Markus Armbruster, 2013/01/16
[Qemu-trivial] [PATCH v2 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename(), Markus Armbruster, 2013/01/16